Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TargetsNet* from the runtime repo #35589

Merged
merged 3 commits into from
May 4, 2020
Merged

Remove TargetsNet* from the runtime repo #35589

merged 3 commits into from
May 4, 2020

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Apr 28, 2020

No Merge. Part of batched rollout in May: #35202

@ghost
Copy link

ghost commented Apr 28, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@Anipik Anipik requested review from ViktorHofer, safern and ericstj and removed request for ahsonkhan, steveharter, layomia and jozkee April 28, 2020 23:04
@ViktorHofer ViktorHofer added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 29, 2020
eng/referenceFromRuntime.targets Outdated Show resolved Hide resolved
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's follow-up work needed to support net5.0. I will handle that in my PR.

@ViktorHofer ViktorHofer merged commit 0ac72ac into dotnet:master May 4, 2020
@ViktorHofer
Copy link
Member

ViktorHofer commented May 4, 2020

There were test failures that I will log later.

@ViktorHofer ViktorHofer removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 6, 2020
@Anipik Anipik deleted the itemGroup branch May 8, 2020 19:49
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants