[runtime] Fix Mono BStr marshaling, cleanup IL generation #35804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, while the previous 4 bytes contain the size, the actual allocation is either 4 or 8 bytes depending on the platform! See https://github.com/dotnet/runtime/blob/fcd862e06413a000f9cafa9d2f359226c60b9b42/src/coreclr/tests/src/Common/Platform/platformdefines.cpp#L418
Also makes BStr changes netcore-only and enables AnsiBStr test. No TBStr test appears to exist.
CoffeeFlux
requested review from
alexischr,
lambdageek,
lewurm,
thaystg and
vargaz
as code owners
4 tasks
alexischr
reviewed
May 16, 2020
|
https://docs.microsoft.com/en-us/previous-versions/windows/desktop/automat/bstr has BSTR always have a four-byte integer for the length. Is this a "different" BSTR? |
lambdageek
approved these changes
May 18, 2020
There was a problem hiding this comment.
LGTM, in general.
Nits:
- It'd be great to have a wall of text somewhere summarizing the string types and how we choose to marshal them in (netcore & classic) Mono
- Address Alexis'
(guint32*)s - 2comment - Maybe
bstr_set_lengthas a little helper to collect the pointer arithmetic.
I like conv_str_inverse
alexischr
approved these changes
May 26, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks in recent string marshaling work and enables a subset of tests that now run successfully. It's possible that this fixes or changes the failure on other tests, but I've only checked the StringMarshalling ones.
Status of string marshaling of this PR:
Followup work:
conv_to_icall