Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable JIT.HardwareIntrinsics NotSupported runtime tests on Mono #35901

Merged
merged 2 commits into from
May 6, 2020

Conversation

safern
Copy link
Member

@safern safern commented May 6, 2020

@naricc disabling these tests on Mono as I've seen some failures not related to the issue linked for the coreclr disable section.

cc: @tannergooding

@ghost
Copy link

ghost commented May 6, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern safern changed the title Disable JIT.HardwareIntrinsics NotSupported runtime tests Disable JIT.HardwareIntrinsics NotSupported runtime tests on Mono May 6, 2020
@safern
Copy link
Member Author

safern commented May 6, 2020

Since the fix for the coreclr test failure is already in PR, I reverted that change and only kept disabling the tests for Mono.

@tannergooding
Copy link
Member

@safern, do you have a link to one of the failing tests? It would be good to ensure we have a corresponding issue

@safern
Copy link
Member Author

safern commented May 6, 2020

I think @naricc will follow up on those issues later, not sure what the process is there, but just following what he has been doing for other runtime tests failing on Mono.

This is part of the logs:

+ /tmp/helix/working/985108B8/p/corerun /tmp/helix/working/985108B8/p/xunit.console.dll JIT/HardwareIntrinsics/JIT.HardwareIntrinsics.XUnitWrapper.dll -parallel collections -nocolor -noshadow -xml testResults.xml -trait TestGroup=JIT.HardwareIntrinsics
CLR: Managed code called FailFast, saying "Infinite recursion during resource lookup within System.Private.CoreLib.  This may be a bug in System.Private.CoreLib, or potentially in certain extensibility points such as assembly resolve events or CultureInfo names.  Resource name: Arg_DllNotFoundException"

https://helix.dot.net/api/2019-06-17/jobs/f4125527-3371-4e3c-9661-841c9b5a2b9b/workitems/JIT.HardwareIntrinsics/files/console.430327d5.log

@tannergooding
Copy link
Member

Thanks! I'd guess this is one of the cases where mono is hitting an intrinsic they don't implement yet.

@naricc
Copy link
Contributor

naricc commented May 6, 2020

It's probably best to just create a new issue for mono with what information you have and link it in the issues.targets as part of this change.

@safern
Copy link
Member Author

safern commented May 6, 2020

@naricc can you take care of that?

@naricc
Copy link
Contributor

naricc commented May 6, 2020

@naricc can you take care of that?

Sure, here is the issue: #35906. I can add it to issues.targets after you merge this change.

@safern safern merged commit e4b9fcf into dotnet:master May 6, 2020
@safern safern deleted the DisableHwiRuntimeTests branch May 6, 2020 22:00
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants