Use TargetFramework conditions consistently in libraries #35956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @ViktorHofer |
ericstj
reviewed
May 7, 2020
| @@ -97,6 +97,44 @@ When building an individual project the `BuildTargetFramework` and `TargetOS` wi | |||
| - .NET Framework latest -> `$(NetFrameworkCurrent)-Windows_NT` | |||
|
|
|||
| # Library project guidelines | |||
|
|
|||
| ## TargetFramework conditions | |||
There was a problem hiding this comment.
Should we call out that $(TargetFramework) should be avoided in PropertyGroup conditions (unless those are in a second PropertyGroup)?
There was a problem hiding this comment.
Do you know if we're going to validate that? I recall at one point we talked about it.
There was a problem hiding this comment.
I would prefer to not add infra for that and instead push on the project system / msbuild team to make progress on the actual issue.
|
Feedback is addressed. Someone pls approve :D |
safern
reviewed
May 8, 2020
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Show resolved
Hide resolved
Anipik
reviewed
May 8, 2020
|
Ping reviewers, please approve :) |
Anipik
approved these changes
May 11, 2020
ericstj
approved these changes
May 11, 2020
safern
approved these changes
May 11, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the docs commit for the desired behavior: b0b09c6.
Additional cleanup:
Rootnamespace,AssemblyName)cc @ericstj