Support async KeyValuePair (de)serialization #36607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
May 17, 2020
steveharter
reviewed
May 20, 2020
...ystem.Text.Json/src/System/Text/Json/Serialization/Converters/Value/KeyValuePairConverter.cs
Show resolved
Hide resolved
jozkee
reviewed
May 20, 2020
...tem/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs
Show resolved
Hide resolved
jozkee
reviewed
May 20, 2020
...tem/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs
Show resolved
Hide resolved
jozkee
reviewed
May 20, 2020
...ystem.Text.Json/src/System/Text/Json/Serialization/Converters/Value/KeyValuePairConverter.cs
Outdated
Show resolved
Hide resolved
|
Do we have stream-based tests with KeyValuePair? |
jozkee
reviewed
May 20, 2020
jozkee
reviewed
May 20, 2020
...braries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.KeyValuePair.cs
Show resolved
Hide resolved
jozkee
reviewed
May 20, 2020
...braries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.KeyValuePair.cs
Outdated
Show resolved
Hide resolved
Yes, see the diff in |
layomia
commented
May 22, 2020
| { | ||
| // Used for value converters that need to re-enter the serializer since it will support JsonPath | ||
| // and reference handling. | ||
| internal abstract class JsonValueConverter<T> : JsonConverter<T> |
There was a problem hiding this comment.
This converter type may come back depending on work in #36785.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the KeyValuePair converter to use logic for deserializing with parameterized ctors and leverage the async support (for reading and writing).
Fixes #32148 (no longer applicable following this change).