-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No retyping arm/arm64. #36866
Merged
Merged
No retyping arm/arm64. #36866
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5695852
Add more test cases specific to SIMD* handling.
319f6dc
Enable for arm/arm64.
097cb9f
Support !compDoOldStructRetyping for arm/arm64.
e72efdc
Review feedback.
f022893
Return `JitDoOldStructRetyping`.
315c24a
a small workaround for default arm64 behaviour.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10191,8 +10191,19 @@ GenTree* Compiler::fgMorphBlockOperand(GenTree* tree, var_types asgType, unsigne | |
} | ||
else if (effectiveVal->TypeGet() != asgType) | ||
{ | ||
GenTree* addr = gtNewOperNode(GT_ADDR, TYP_BYREF, effectiveVal); | ||
effectiveVal = gtNewIndir(asgType, addr); | ||
if (effectiveVal->IsCall()) | ||
{ | ||
#ifdef DEBUG | ||
GenTreeCall* call = effectiveVal->AsCall(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
assert(call->TypeGet() == TYP_STRUCT); | ||
assert(blockWidth == info.compCompHnd->getClassSize(call->gtRetClsHnd)); | ||
#endif | ||
} | ||
else | ||
{ | ||
GenTree* addr = gtNewOperNode(GT_ADDR, TYP_BYREF, effectiveVal); | ||
effectiveVal = gtNewIndir(asgType, addr); | ||
} | ||
} | ||
} | ||
else | ||
|
@@ -11941,7 +11952,7 @@ GenTree* Compiler::fgMorphSmpOp(GenTree* tree, MorphAddrContext* mac) | |
|
||
return tree; | ||
} | ||
if (tree->TypeIs(TYP_STRUCT) && op1->OperIs(GT_OBJ, GT_BLK)) | ||
if (varTypeIsStruct(tree) && op1->OperIs(GT_OBJ, GT_BLK)) | ||
{ | ||
assert(!compDoOldStructRetyping()); | ||
GenTree* addr = op1->AsBlk()->Addr(); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if temporary, I think it would be good to 1) describe in what way it is different (in particular talk about the special handling required for SIMD types, soon to be additional ones for x64/ux, that are passed in a single register), and 2) rename it to be something like
compMethodReturnsMultiRegRegTypeAlternate
.