Enable Activity tracking on generic host #37892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shirhatti could you please add a little test for the generic host with logging the activity Ids? |
|
CC @davidfowl |
tarekgh
approved these changes
Jun 15, 2020
maryamariyan
added
area-Extensions-Logging
area-Extensions-Hosting
and removed
area-Microsoft.Extensions
area-Extensions-Logging
labels
maryamariyan
approved these changes
Jun 15, 2020
davidfowl
approved these changes
Jun 15, 2020
shirhatti
commented
Jun 22, 2020
| @@ -60,6 +61,37 @@ public void CreateDefaultBuilder_RegistersEventSourceLogger() | |||
| args.Payload.OfType<string>().Any(p => p.Contains("Request starting"))); | |||
| } | |||
|
|
|||
| [Fact] | |||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/34580", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] | |||
There was a problem hiding this comment.
Not sure if this is still needed, but all Hosting tests had this attribute
There was a problem hiding this comment.
That is to skip running tests on mono. They should be tracked with #34582 now that 34580 is closed as its dupe.
shirhatti
force-pushed
the
shirhatti/generichostactivitytracking
branch
from
474d49d
to
7aa8777
Compare
|
@saurabh500 some test failures showing up on your last commit: https://dev.azure.com/dnceng/public/_build/results?buildId=698089&view=ms.vss-test-web.build-test-results-tab&runId=21632144&resultId=101794&paneView=debug |
shirhatti
force-pushed
the
shirhatti/generichostactivitytracking
branch
from
0f9b5c8
to
19ff74a
Compare
tarekgh
approved these changes
Jun 22, 2020
|
@Anipik does this change will be included in previews 7? I am asking because I don't know if you already snapped for it yet. |
|
Yep it made to preview7 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.