addressing some missing feedback Relating to Browser #38968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @ViktorHofer |
safern
reviewed
Jul 9, 2020
jkotas
reviewed
Jul 9, 2020
safern
reviewed
Jul 9, 2020
safern
reviewed
Jul 9, 2020
|
Could you please resolve conflicts? |
safern
approved these changes
Jul 9, 2020
marek-safar
reviewed
Jul 9, 2020
stephentoub
reviewed
Jul 9, 2020
src/libraries/System.Data.Odbc/src/System/Data/Odbc/ODBC32.Common.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
akoeplinger
reviewed
Jul 9, 2020
...ries/System.Configuration.ConfigurationManager/src/System/Configuration/ClientConfigPaths.cs
Show resolved
Hide resolved
|
@safern @ericstj @akoeplinger can you take another look ? i made some changes. (they are small but no harm in getting an another pair of eyes) |
safern
reviewed
Jul 10, 2020
| @@ -149,7 +149,7 @@ | |||
| Link="Common\System\Text\ValueStringBuilder.cs" /> | |||
| </ItemGroup> | |||
| <!-- Unix --> | |||
| <ItemGroup Condition=" '$(TargetsUnix)' == 'true' and '$(TargetsAndroid)' != 'true' and '$(TargetsiOS)' != 'true' and '$(TargetstvOS)' != 'true' and '$(TargetsBrowser)' != 'true'"> | |||
| <ItemGroup Condition="'$(TargetsUnix)' == 'true' and '$(TargetsAndroid)' != 'true' and '$(TargetsiOS)' != 'true' and '$(TargetstvOS)' != 'true'"> | |||
There was a problem hiding this comment.
Nit: you can simplify this with TargetsMobile
There was a problem hiding this comment.
i will make this change in the next follow up pr for browser
safern
approved these changes
Jul 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR #37944