Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Ordinal Ignore Case Optimization changes #40962

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Aug 18, 2020

This is porting the changes from the PR #40910.

@ghost
Copy link

ghost commented Aug 18, 2020

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

@tarekgh
Copy link
Member Author

tarekgh commented Aug 18, 2020

#37919
#26054
#40942

@tarekgh
Copy link
Member Author

tarekgh commented Aug 18, 2020

@safern @GrabYourPitchforks this is straight porting the changes you have approved to RC1 branch.

CC @danmosemsft @ericstj @Anipik

@danmoseley
Copy link
Member

Port approved

Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tarek! 😸

@tarekgh
Copy link
Member Author

tarekgh commented Aug 18, 2020

The failure in the CI is tracked by the issue #39009

https://helix.dot.net/api/2019-06-17/jobs/61043e95-3b03-4c8c-bf90-1b1b5cf6fb28/workitems/System.DirectoryServices.Protocols.Tests/console%20

ushd .
/home/helixbot/work/A434096D/p/dotnet exec --runtimeconfig System.DirectoryServices.Protocols.Tests.runtimeconfig.json --depsfile System.DirectoryServices.Protocols.Tests.deps.json xunit.console.dll System.DirectoryServices.Protocols.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
~/work/A434096D/w/A872094B/e ~/work/A434096D/w/A872094B/e
  Discovering: System.DirectoryServices.Protocols.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.DirectoryServices.Protocols.Tests (found 343 of 369 test cases)
  Starting:    System.DirectoryServices.Protocols.Tests (parallel test collections = on, max threads = 2)
dotnet: ../nptl/pthread_mutex_lock.c:79: __pthread_mutex_lock: Assertion `mutex->__data.__owner == 0' failed.
./RunTests.sh: line 161: 95592 Aborted                 "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.DirectoryServices.Protocols.Tests.runtimeconfig.json --depsfile System.DirectoryServices.Protocols.Tests.deps.json xunit.console.dll System.DirectoryServices.Protocols.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE
~/work/A434096D/w/A872094B/e
----- end Tue Aug 18 17:35:36 UTC 2020 ----- exit code 134 ----------------------------------------------------------
exit code 134 means SIGABRT Abort. Managed or native assert, or runtime check such as heap corruption, caused call to abort(). Core dumped.

@tarekgh tarekgh merged commit c357618 into dotnet:release/5.0-rc1 Aug 18, 2020
@tarekgh tarekgh deleted the release/5.0-rc1 branch August 18, 2020 18:28
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants