Search libgdiplus in /usr/local/lib on macOS #41503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Apple's Hardened Runtime, `/usr/local/lib` is not searched for `dlopen(3)` calls. Today, some brew packages, such as `mono-libgdiplus` (used by System.Drawing) are installed in `/usr/local/lib`. This causes `DllNotFoundException` and user is supposed to either: 1. manually create a symlink to `/usr/local/lib/libgdiplus.dylib`. 2. export `LD_LIBRARY_PATH`, `DYLD_LIBRARY_PATH` or `DYLD_FALLBACK_LIBRARY_PATH` to `/usr/local/lib`. 3. remove signature from dotnet binary: `sudo codesign --remove-signature $(command -v dotnet)` This patch adds a fallback lookup for libgdiplus.dylib, to avoid workaround on macOS (as it is done for Linux: `libgdiplus.so` falls back to `libgdiplus.so.0`). Also removed `LIBSEARCHPATH` which is unused since 8d5e610.
|
Tagging subscribers to this area: @safern, @tannergooding |
|
Would it be possible to consider it for 5.0? It helps the common macOS use-case, where code is using |
|
cc: @ericstj for that question |
|
Has anything made this harder more recently, or has this bug been present since 2.x? |
|
It has been present since 2.x if I remember correctly. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Apple's Hardened Runtime,
/usr/local/libis not searched fordlopen(3)calls.Today, some brew packages, such as
mono-libgdiplus(used bySystem.Drawing) are installed in
/usr/local/lib. This causesDllNotFoundExceptionand user is supposed to either:/usr/local/lib/libgdiplus.dylib.LD_LIBRARY_PATH,DYLD_LIBRARY_PATHorDYLD_FALLBACK_LIBRARY_PATHto/usr/local/lib.sudo codesign --remove-signature $(command -v dotnet)This patch adds a fallback lookup for libgdiplus.dylib, to avoid
workaround on macOS (as it is done for Linux:
libgdiplus.sofallsback to
libgdiplus.so.0).Also removed
LIBSEARCHPATHwhich is unused since 8d5e610.cc @janvorli