Fix nullable annotation on ISite.Container #42918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @roji, @ajcvickers |
This was referenced Sep 30, 2020
stephentoub
added
the
breaking-change
ghost
added
the
needs-breaking-change-doc-created
|
@jeffhandley, I've marked this as breaking-change. I expect we'll want to have a single list for .NET 6 of all the APIs for which we fixed annotations in a way that could result in more warnings. |
29 tasks
|
dotnet/docs#21202 was created to aggregate the fixed annotations in 6.0; this API was added to that issue. |
jeffhandley
removed
the
needs-breaking-change-doc-created
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42742
@buyaa-n, I only annotated Container as I'm not convinced Component should be nullable as well. I suggest we wait to see if there's any feedback on it. There's very few implementations / call sites to it / docs about it to go by.