Handle unsupported browser warnings #43363

buyaa-n · 2020-10-13T16:45:30Z

Fixes #42335

This PR will:

Add MSBuild item <SupportedPlatform Include="browser" /> for the browser targets so that we could see warning if it accesses and API unsupported on browser.
Tried to resolve warnings/errors that currently exist with the annotations that have been made. Mostly suppressed them as they are unconditionally accessing APIs having assembly-level Unsupported on browser attribute

The warnings found attached unsupported browser warnings.txt

src/libraries/Common/src/System/Net/Security/SslClientAuthenticationOptionsExtensions.cs

src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs

src/libraries/System.Net.HttpListener/src/System/Net/HttpListener.cs

src/libraries/System.Net.HttpListener/src/System/Net/HttpListenerResponse.cs

src/libraries/System.Net.HttpListener/src/System/Net/Managed/ChunkStream.cs

src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs

src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpEndPointListener.cs

src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpListenerRequest.Managed.cs

src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpResponseStream.Managed.cs

...libraries/System.Net.HttpListener/src/System/Net/Managed/WebSockets/HttpWebSocket.Managed.cs

...s/System.Security.Cryptography.Algorithms/src/System.Security.Cryptography.Algorithms.csproj

src/libraries/Common/src/System/Net/Security/SslClientAuthenticationOptionsExtensions.cs

src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs

src/libraries/System.Net.HttpListener/src/System/Net/HttpListener.cs

src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs

src/libraries/System.Net.HttpListener/ref/System.Net.HttpListener.cs

src/libraries/System.Net.HttpListener/src/System/Net/HttpListener.cs

src/libraries/System.Net.HttpListener/src/System/Net/HttpListenerResponse.cs

src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs

src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpEndPointListener.cs

…rowser_support

...aries/System.Security.Cryptography.Algorithms/ref/System.Security.Cryptography.Algorithms.cs

src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs

src/mono/netcore/System.Private.CoreLib/System.Private.CoreLib.csproj

...ibraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/PropertyDescriptor.cs

src/libraries/System.Diagnostics.Tracing/ref/System.Diagnostics.Tracing.Counters.cs

jeffhandley

There are only a few #pragma warning disable statements left that don't have issues applied to them: XmlDownloadManagerAsync and Transaction. Is it appropriate to file follow-up issues for those too?

src/libraries/System.Linq.Parallel/Directory.Build.props

src/libraries/System.Net.WebSockets.WebSocketProtocol/Directory.Build.props

src/libraries/System.Security.Permissions/Directory.Build.props

buyaa-n · 2020-11-20T22:36:14Z

There are only a few #pragma warning disable statements left that don't have issues applied to them: XmlDownloadManagerAsync and Transaction. Is it appropriate to file follow-up issues for those too?

Those do not need an issue, safe to suppress scenarios, improved the suppression comments

…scriptionProvider.CreateInstance and related updates

ghost · 2020-11-25T18:14:56Z

Hello @buyaa-n!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.