Respect reloadOnChange in UserSecrets in DefaultBuilder #43807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eerhardt, @maryamariyan |
|
@eerhardt Should I add ActiveIssue attribute to my test like in all HostTests? |
eerhardt
reviewed
Oct 27, 2020
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/AssemblyInfo.cs
Show resolved
Hide resolved
Yes, it looks like that is needed, given your new test is failing in CI:
|
maryamariyan
approved these changes
Oct 28, 2020
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs
Outdated
Show resolved
Hide resolved
|
The test failure is #43953 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40020
Yet another try to fix and test it