Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build archives or installers for Mono builds. #44656

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

jkoritzinsky
Copy link
Member

Building archives and installers here was leading to duplicate assets, which is causing publishing to BAR to fail.

This PR disables building the archives and installers for Mono builds (only build the packs).

Official build located at: https://dev.azure.com/dnceng/internal/_build/results?buildId=885715&view=results

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, referencing these two generates the Installers and Archives based on some itemgroup that available?

@jkoritzinsky
Copy link
Member Author

Yes, referencing these packages hooks the installer and archive generation targets into the build.

@jkoritzinsky
Copy link
Member Author

Failure is a transient issue. Opened up a tracking bug for it. #44657

@jkoritzinsky jkoritzinsky merged commit 72eefe3 into dotnet:master Nov 13, 2020
@jkoritzinsky jkoritzinsky deleted the no-mono-archives branch November 13, 2020 20:12
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants