Fix deadlock in TestEventListener and re-enable ArrayPool DiagnosticEvent tests #45469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsFix #42899. TestEventListener has a deadlock in its implementation where it tries to lock the The fix is simple - calling
|
stephentoub
reviewed
Dec 2, 2020
src/libraries/Common/tests/System/Diagnostics/Tracing/TestEventListener.cs
Show resolved
Hide resolved
stephentoub
reviewed
Dec 2, 2020
src/libraries/Common/tests/System/Diagnostics/Tracing/TestEventListener.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Dec 2, 2020
src/libraries/Common/tests/System/Diagnostics/Tracing/TestEventListener.cs
Show resolved
Hide resolved
This was referenced Dec 2, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42899.
TestEventListener has a deadlock in its implementation where it tries to lock the
_eventSourceListand callEnableEventSourcewhich can try to take the EventListener lock, while the overriden OnEventSourceCreated method tries to grab that same lock (_eventSourceList) while holding the EventListener lock.The fix is simple - calling
EnableEventSourcedoesn't need to be inside the_eventSourceListlock.