Update first-class-structs.md #45512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
|
@dotnet/jit-contrib PTAL |
sandreenko
approved these changes
Dec 3, 2020
| @@ -213,16 +225,21 @@ This would be done in multiple phases: | |||
| for a general idea of the kinds of VM changes that may be required. | |||
| * Defer retyping of struct return types (`Compiler::impFixupStructReturnType()` and | |||
| `Compiler::impFixupCallStructReturn()`) | |||
| * This is probably the "right" way to fix [#13355](https://github.com/dotnet/runtime/issues/13355). | |||
| * This has largely (fully?) been addressed with [#37745 Disable JitDoOldStructRetyping by default](https://github.com/dotnet/runtime/pull/37745). | |||
There was a problem hiding this comment.
I would say it was fully addressed.
| @@ -213,16 +225,21 @@ This would be done in multiple phases: | |||
| for a general idea of the kinds of VM changes that may be required. | |||
| * Defer retyping of struct return types (`Compiler::impFixupStructReturnType()` and | |||
| `Compiler::impFixupCallStructReturn()`) | |||
| * This is probably the "right" way to fix [#13355](https://github.com/dotnet/runtime/issues/13355). | |||
| * This has largely (fully?) been addressed with [#37745 Disable JitDoOldStructRetyping by default](https://github.com/dotnet/runtime/pull/37745). | |||
| * Next, eliminate the "pessimizations". | |||
| * For cases where `GT_LCL_FLD` is currently used to "retype" the struct, change it to use *either* | |||
| `GT_LCL_FLD`, if it is already address-taken, or to use a `GT_BITCAST` otherwise. | |||
There was a problem hiding this comment.
I would add #11413 to this list.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.