Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable apphost tests on Linux #45976

Merged
merged 8 commits into from
Dec 22, 2020
Merged

Disable apphost tests on Linux #45976

merged 8 commits into from
Dec 22, 2020

Conversation

agocke
Copy link
Member

@agocke agocke commented Dec 11, 2020

There is a race condition somewhere in these tests which is causing #44657

There is a race condition somewhere in these tests which is causing dotnet#44657
@ghost
Copy link

ghost commented Dec 11, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

There is a race condition somewhere in these tests which is causing #44657

Author: agocke
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@agocke
Copy link
Member Author

agocke commented Dec 11, 2020

We just need a corresponding PR to enable these tests in staging, then we can move forward.

@danmoseley
Copy link
Member

We just need a corresponding PR to enable these tests in staging

That isn’t done in this same repo?

@agocke agocke marked this pull request as ready for review December 14, 2020 17:48
@agocke
Copy link
Member Author

agocke commented Dec 14, 2020

@danmosemsft It is, and the change could just be another commit in this PR, I just don't know how to do it. I think @safern was working on enabling the staging build?

@safern
Copy link
Member

safern commented Dec 14, 2020

I think @safern was working on enabling the staging build?

The staging build already exists, it is defined in runtime-staging.yml, however I'm working on making it simpler to move things around to the staging pipeline as right now you need to delete things from one yml and move it to another which is less than ideal.

@agocke
Copy link
Member Author

agocke commented Dec 14, 2020

So is this test already running in the staging PR on Linux?

@safern
Copy link
Member

safern commented Dec 15, 2020

So is this test already running in the staging PR on Linux?

No, the staging pipeline is only running tests on iOS and Android (devices so arm64).

@agocke
Copy link
Member Author

agocke commented Dec 15, 2020

@safern How would I replicate the unit test behavior? Run the installer tests on Linux amd64?

@safern
Copy link
Member

safern commented Dec 22, 2020

Merging as the tests are now running in staging pipeline for Linux x64.

@safern safern merged commit 81771ef into dotnet:master Dec 22, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants