Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove targets* platform condition from project references #46377

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Remove targets* platform condition from project references #46377

merged 3 commits into from
Jan 4, 2021

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Dec 23, 2020

Related to #46338

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

safern
safern reviewed Dec 24, 2020
View reviewed changes
src/libraries/System.Net.Http/src/System.Net.Http.csproj
@@ -674,4 +673,7 @@
<ItemGroup>
<None Include="Resources\SR.resx" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(LibrariesProjectRoot)System.Security.Cryptography.OpenSsl\src\System.Security.Cryptography.OpenSsl.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenSSL is a Unix only project, can this cause any issues on non-Unix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a platform independent configuration in openssl

@ViktorHofer
Copy link
Member

I'm worried about the additional references added to the assemblies. Did you consider setting Targets* properties to true during restore? A project is being restored when <MSBuildRestoreSessionId /> is not empty.

@Anipik
Copy link
Contributor Author

Anipik commented Jan 4, 2021 •
edited
Loading

I'm worried about the additional references added to the assemblies

I think the compiler removes the additional references to assemblies which are not used. Compiler only adds the references its using. I verified this as well using system.drawing.common dll, where the system.events references is only present in windows assembly.

safern
safern approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long you have made sure the produced packages/assemblies are the same as before the change.

@Anipik Anipik merged commit fd5609d into dotnet:master Jan 4, 2021
@ViktorHofer
Copy link
Member

That's right, but it also increases build times on configurations that don't need the P2P. Did you consider setting the Target* to true during restore?

@Anipik
Copy link
Contributor Author

Anipik commented Jan 12, 2021

That's right, but it also increases build times on configurations that don't need the P2P. Did you consider setting the Target* to true during restore?

I can take a look at setting Targets* true during restore

@Anipik Anipik deleted the remove branch January 30, 2021 21:41
@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@safern safern safern approved these changes

@ericstj ericstj Awaiting requested review from ericstj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anipik @Dotnet-GitSync-Bot @ViktorHofer @safern