Skip NativeLibrary abstraction for Windows-specific system libraries #47013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is mostly cosmetic change to avoid hitting reflection and creating reflection objects on these paths.
|
jkoritzinsky
approved these changes
Jan 14, 2021
This was referenced Jan 15, 2021
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Feb 1, 2021
…Library.*Load* on Mono. dotnet/runtime#47013 changed how kernel32.dll and Ws2_32.dll gets loaded on Windows. Instead of loading using NativeLibrary.Load these system libraries are now loaded directly using LoadLibraryEx, but symbols are still handled through NativeLibrary. This short-circuits some logic in Mono that assumes all libraries gets loaded through NativeLibrary.Load. Fix adds ability to use use OS handle in calls to NativeLibrary.GetExport/Free regardless if that handle was retrieved through a call to NativeLibrary.*Load* or not. Fix is not platform specific since the same scenarios can apply to other platforms as well.
lateralusX
added a commit
to lateralusX/runtime
that referenced
this pull request
Feb 2, 2021
…oadLibraryEx. dotnet#47013 changed how kernel32.dll and Ws2_32.dll gets loaded on Windows. Instead of loading using NativeLibrary.Load these system libraries are now loaded directly using LoadLibraryEx, but symbols are still handled through NativeLibrary. This short-circuits some logic in Mono that assumes all libraries gets loaded through NativeLibrary.Load. Fix adds ability to use passed in HMODULE when not finding a matching library in our native library cache and use it directly in call to GetProcAddress on Windows, inline with CoreClr behavior.
lateralusX
added a commit
that referenced
this pull request
Feb 4, 2021
…Library.*Load* on Mono. (#47705) Handle NativeLibrary.GetExport on libs loaded with Interop.Kernel32.LoadLibraryEx. #47013 changed how kernel32.dll and Ws2_32.dll gets loaded on Windows. Instead of loading using NativeLibrary.Load these system libraries are now loaded directly using LoadLibraryEx, but symbols are still handled through NativeLibrary. This short-circuits some logic in Mono that assumes all libraries gets loaded through NativeLibrary.Load. Fix adds ability to use passed in HMODULE when not finding a matching library in our native library cache and use it directly, inline with CoreClr behavior. * Handle NativeLibrary GetExport/Free using IntPtr library OS handle xplat. * Disable additional System.Drawing.Common tests due to missing COM support.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly cosmetic change to avoid hitting reflection and creating reflection objects on these paths.