Search libgdiplus in macports install location #47373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @tannergooding Issue DetailsWhen $ port install libgdiplus
$ port contents libgdiplus
Port libgdiplus contains:
/opt/local/lib/libgdiplus.0.dylib
/opt/local/lib/libgdiplus.a
/opt/local/lib/libgdiplus.dylib
/opt/local/lib/pkgconfig/libgdiplus.pc
/opt/local/share/doc/libgdiplus/AUTHORS
/opt/local/share/doc/libgdiplus/COPYING
/opt/local/share/doc/libgdiplus/ChangeLog
/opt/local/share/doc/libgdiplus/LICENSE
/opt/local/share/doc/libgdiplus/NEWS
/opt/local/share/doc/libgdiplus/README.md
/opt/local/share/doc/libgdiplus/TODOPR adds
|
|
@akoeplinger I'm not familiar with macports. Is this still a trusted libgdiplus channel? If so this change seems reasonable. |
|
It's as trusted as homebrew so yeah this seems fine :) |
akoeplinger
approved these changes
Jan 25, 2021
|
Hello @akoeplinger! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
x86 failure is #47374. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
libgdiplusis installed via macports,System.TypeInitializationExceptionexception is thrown.This is because macports installs the library in
/opt/local/lib.PR adds
/opt/local/lib/libgdiplus.dylibas a well-known probing path.