Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Socket.SendFile tests and extend coverage #47479

Merged
merged 13 commits into from
Jan 27, 2021
Merged

Refactor Socket.SendFile tests and extend coverage #47479

merged 13 commits into from
Jan 27, 2021

Commits on Jan 25, 2021

  1. use TempFile instead of FileCleanupTestBase

    @antonfirsov
    antonfirsov committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    57b7743 View commit details
    Browse the repository at this point in the history

  2. most SendFile tests refactored

    @antonfirsov
    antonfirsov committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    f115490 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. change UdpConnection_ThrowsException because of dotnet#47472

    @antonfirsov
    antonfirsov committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    5a01870 View commit details
    Browse the repository at this point in the history

  2. fix SocketHelperApm.SendFileAsync

    @antonfirsov
    antonfirsov committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    a858a4c View commit details
    Browse the repository at this point in the history

  3. IncludeFile_Success

    @antonfirsov
    antonfirsov committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    7ecc497 View commit details
    Browse the repository at this point in the history

  4. SendFileGetsCanceledByDispose

    @antonfirsov
    antonfirsov committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    e7c1188 View commit details
    Browse the repository at this point in the history

  5. delete the old test class

    @antonfirsov
    antonfirsov committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    1d8dbcf View commit details
    Browse the repository at this point in the history

  6. FileDoesNotExist_ThrowsFileNotFoundException

    @antonfirsov
    antonfirsov committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    8ad918c View commit details
    Browse the repository at this point in the history

  7. SliceBuffers_Success

    @antonfirsov
    antonfirsov committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    8ad1631 View commit details
    Browse the repository at this point in the history

  8. better comment

    @antonfirsov
    antonfirsov committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    197c90f View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. SendFileBase<T> -> SendFile<T>

    @antonfirsov
    antonfirsov committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    7f6b39a View commit details
    Browse the repository at this point in the history

  2. split out large case of IncludeFile_Success to OuterLoop

    @antonfirsov
    antonfirsov committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    71d00c6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into sockets/SendFile-test-refactor 

    # Conflicts:
#	src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketTestHelper.cs
    @antonfirsov
    antonfirsov committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    8ab5142 View commit details
    Browse the repository at this point in the history