[Release/5.0] Fix GDI handle leak in Graphics.DrawIcon #48189
Conversation
|
Tagging subscribers to this area: @safern, @tannergooding Issue DetailsBackport of #47836 Customer ImpactIn any application that draws a lot of icons to a graphics object associated to the current device context we would leak GDI+ handles as observed in the issue, which could potentially cause application crashes if we exceed the GDI handles limit imposed by the OS. Regression?Yes, caused by dotnet/corefx@f807df6 in 5.0. TestingManual testing and also included a regression test which was failing before the fix, the test and fix have been in master for about a week already and the test is pretty stable, we haven't seen failures from it or any other System.Drawing test. RiskLow, the fix is just making sure we call GDI.DeleteObject on a handle that is no longer used. cc: @danmoseley @ericstj @Anipik
|
|
Updated template to note this was customer reported. |
safern
added
Servicing-approved
|
It was approved over email |
|
Failures are unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #47836
Fixes #46789
Customer Impact
Customer reported a GDI resource leak in their WinForms application after they targeted it to NET 5.0.
In any application that draws a lot of icons to a graphics object associated to the current device context we would leak GDI+ handles as observed in the issue, which could potentially cause application crashes if we exceed the GDI handles limit imposed by the OS.
This impacts winforms as System.Drawing.Common is part of their shared framework.
Regression?
Yes, caused by dotnet/corefx@f807df6 in 5.0.
Testing
Manual testing and also included a regression test which was failing before the fix, the test and fix have been in master for about a week already and the test is pretty stable, we haven't seen failures from it or any other System.Drawing test.
Risk
Low, the fix is just making sure we call GDI.DeleteObject on a handle that is no longer used.
cc: @danmoseley @ericstj @Anipik