Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json converters not disposing enumerators #48322

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Fix json converters not disposing enumerators #48322

merged 2 commits into from
Feb 16, 2021

Conversation

NewellClark
Copy link
Contributor

Fix issue #46349 in System.Text.Json

@NewellClark
Fix undisposed enumerators
9c6d1a5 
-Fix converters not disposing enumerators (issue dotnet#46349)
-Add tests
@ghost
Copy link

ghost commented Feb 16, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix issue #46349 in System.Text.Json

Author: NewellClark
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@NewellClark
Copy link
Contributor Author

Just hit issue #35752. Rerunning.

@runfoapp runfoapp bot mentioned this pull request Feb 16, 2021
Closed
steveharter
steveharter approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@steveharter steveharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; verified all collection types are modified except the non-generic IEnumerable-based ones which don't implement IDisposable.

layomia
layomia approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@layomia layomia merged commit 8f91099 into dotnet:master Feb 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveharter steveharter steveharter approved these changes

@layomia layomia layomia approved these changes

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

@jozkee jozkee Awaiting requested review from jozkee

Assignees
No one assigned
Labels
area-System.Text.Json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.Text.Json doesn't call IEnumerator<T>.Dispose
3 participants
@NewellClark @steveharter @layomia