Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated ILLink PackageReference and update target version of the SDK to 6.0 #48462

Merged
merged 14 commits into from
Feb 25, 2021

Commits on Feb 20, 2021

  1. Remove duplicated ILLink PackageReference

    The Arcade.SDK already package refrences the ILLink package. The
    duplicate reference in illink.targets caused SDK errors as the Arcade
    reference has IsImplicitlyDefined set which doesn't allow an additional
    reference with the same identity.
    
    Also, as the ILLink package already exposes the path to the assembly via
    its props file, using that instead of manually constructing the path to
    the assembly.
    
    The SDK target version update is required as the sequencing of the
    ILLink.props file was wrong and is required for this change. This isn't
    considered a breaking change, as the SDK's minimum required version
    isn't changed.
    ViktorHofer committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    dc3e419 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    558c609 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. Configuration menu
    Copy the full SHA
    19d8823 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Add mega hack workaround

    ViktorHofer committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    b4ba1fd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1abc0d7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6d6a6b6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a033e3f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1e94df5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e5cd041 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Configuration menu
    Copy the full SHA
    045d714 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e05103 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    461f4bc View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Configuration menu
    Copy the full SHA
    abeb581 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b9bd8b View commit details
    Browse the repository at this point in the history