Add test for EventListener consuming ThreadPool events #48487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Feb 19, 2021
josalem
reviewed
Feb 22, 2021
| } | ||
| } | ||
|
|
||
| class EventPipeSmoke |
There was a problem hiding this comment.
nit: can we match the class name to the file name?
|
@sywhang this is on the stale PR list, what is missing before it can be merged? |
…re is coming from
davmason
force-pushed
the
dev/suwhang/eventlistener-threadpool-tests
branch
from
cfc5935
to
2a5d1cc
Compare
|
@josalem can you take another look? The original failures were due to EventPipePayloadDecoder not supporting enums, so I added support for those. |
josalem
approved these changes
Jun 1, 2021
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have any test covering the case where an EventListener is used to consume ThreadPool events. This PR adds one.