Support remaining Aes intrinsics on Arm #48525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
requested review from
kunalspathak,
naricc,
SamMonoRT and
imhameed
fanyang-mono
requested review from
CoffeeFlux,
EgorBo,
lambdageek and
vargaz
as code owners
naricc
reviewed
Feb 19, 2021
| @@ -841,6 +841,11 @@ static SimdIntrinsic crypto_aes_methods [] = { | |||
| {SN_get_IsSupported} | |||
| }; | |||
|
|
|||
| static SimdIntrinsic neon_aes_methods [] = { | |||
| {SN_PolynomialMultiplyWideningLower, OP_XOP_X_X_X, SIMD_OP_ARM64_PMULL64_LOWER}, | |||
There was a problem hiding this comment.
I just realized that for some of these we are only specifying an enum value (SN_whatever), and for some of them we are specifying op codes. Why the difference?
There was a problem hiding this comment.
It depends if it is necessary to have the opcode or not. For SN_get_IsSupported, all we needed to to was
if (id == SN_get_IsSupported) {
EMIT_NEW_ICONST (cfg, ins, supported ? 1 : 0);
return ins;
}
For the methods with op codes that I have been working on, they went through this common logic:
https://github.com/dotnet/runtime/blob/master/src/mono/mono/mini/simd-intrinsics.c#L987-L1021
naricc
approved these changes
Feb 19, 2021
ihameed
approved these changes
Feb 22, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42273:
Add support for