Big-endian fix: Accessing OBJECTHEADER in ImageConverter #50499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @tarekgh Issue DetailsThe GetBitmapStream routine in ImageConverter is supposed to Fixes the ImageConverterTest.ImageWithOleHeader test on
|
campersau
reviewed
Mar 31, 2021
src/libraries/System.Drawing.Common/src/System/Drawing/ImageConverter.cs
Show resolved
Hide resolved
The GetBitmapStream routine in ImageConverter is supposed to skip an embedded OBJECTHEADER structure. However, this structure needs to be read in little-endian mode, not in native byte order. Fixes the ImageConverterTest.ImageWithOleHeader test on big-endian systems.
stephentoub
reviewed
Mar 31, 2021
src/libraries/System.Drawing.Common/src/System/Drawing/ImageConverter.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetBitmapStream routine in ImageConverter is supposed to
skip an embedded OBJECTHEADER structure. However, this
structure needs to be read in little-endian mode, not in
native byte order.
Fixes the ImageConverterTest.ImageWithOleHeader test on
big-endian systems.