Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MONO][WASM] Fix System.ComponentModel.TypeConverter tests by adding missing ILLink dependencies #50645

Merged
merged 4 commits into from
Apr 15, 2021
Merged

[MONO][WASM] Fix System.ComponentModel.TypeConverter tests by adding missing ILLink dependencies #50645

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86a878f
Added missing dependencies for TypeConverter tests.
Mar 31, 2021
b686231
Removed redundant illink descriptors, added comment.
Apr 13, 2021
2125251
ILLink.Descriptor.xml -> ILLink.Descriptors.xml
Apr 13, 2021
addfa26
Removed ILLink descriptors that are no longer needed due to lib fixes.
Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/testing/ILLink.Descriptor.xunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
</type>
<type fullname="Xunit.Sdk.FactDiscoverer" />
</assembly>
<assembly fullname="Microsoft.DotNet.XUnitExtensions" />
<assembly fullname="xunit.core">
<namespace fullname="Xunit" />
</assembly>
<assembly fullname="xunit.runner.utility.netcoreapp10" />
</linker>
21 changes: 21 additions & 0 deletions src/libraries/System.ComponentModel.TypeConverter/tests/ILLink.Descriptor.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<linker>
naricc marked this conversation as resolved.
Show resolved Hide resolved
<assembly fullname="TestUtilities">
<namespace fullname="System" />
<type fullname="System.PlatformDetection" />
</assembly>
<assembly fullname="System" />
<assembly fullname="xunit.runner.utility.netcoreapp10" />
<assembly fullname="Microsoft.DotNet.XUnitExtensions"/>
naricc marked this conversation as resolved.
Show resolved Hide resolved
<assembly fullname="mscorlib" />
naricc marked this conversation as resolved.
Show resolved Hide resolved
<assembly fullname="Castle.Core">
<namespace fullname="Castle.DynamicProxy" />
<type fullname="Castle.DynamicProxy.Internal.CompositionInvocation" />
<type fullname="Castle.DynamicProxy.Internal.AbstractInvocation" />
<type fullname="Castle.DynamicProxy.Internal.InheritanceInvocation" />
</assembly>
<assembly fullname="Moq">
<type fullname="Moq.Internals.InterfaceProxy">
<method signature="System.Void .ctor()" />
</type>
</assembly>
</linker>
3 changes: 3 additions & 0 deletions ...ystem.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,4 +161,7 @@
<LastGenOutput>TestResx.Designer.cs</LastGenOutput>
</EmbeddedResource>
</ItemGroup>
<ItemGroup>
<TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptor.xml" />
</ItemGroup>
</Project>