Stop harvesting old frameworks in some libraries

[ViktorHofer]

The removed configurations (few netstandard1.x, portable*, netcore50, net46)
of the touched packages aren't built anymore. Instead
the already built matching binaries from the latest available packages
are redistributed when packaging these libraries.

Dropping these assets as the minimum supported set of platforms are ones
that support netstandard2.0. For .NET Framework, there's still a net461
configuration present to avoid binding redirect issues.

Contributes to #47530

[ghost]

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The removed configurations (few netstandard1.x, portable*, netcore50)
of the touched packages aren't built anymore. Instead
the already built matching binaries from the latest available packages
are redistributed when packaging these libraries.

Dropping these assets as the minimum supported set of platforms are ones
that support netstandard2.0. For .NET Framework, there's still a net461
configuration present to avoid binding redirect issues.

Contributes to #47530

Author:	ViktorHofer
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[ViktorHofer]

System.Security.AccessControl needs to be delayed until System.IO.Pipes.AccessControl is completed.

[ericstj]

Can you elaborate? What was going wrong here?

[ViktorHofer]

These were the errors that I wasn't sure how to deal with them:

Errors
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework .NETCore,Version=v4.5 should support System.Reflection.Context inbox but contained a reference assemblies: ref/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="netcore45" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework .NETCore,Version=v4.5 should support System.Reflection.Context inbox but contained a implementation assemblies: lib/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="netcore45" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework .NETCore,Version=v4.5.1 should support System.Reflection.Context inbox but contained a reference assemblies: ref/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="netcore451" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework .NETCore,Version=v4.5.1 should support System.Reflection.Context inbox but contained a implementation assemblies: lib/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="netcore451" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework .NETPortable,Version=v4.6,Profile=Profile44 should support System.Reflection.Context inbox but contained a reference assemblies: ref/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="portable46-net451+win81" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework .NETPortable,Version=v4.6,Profile=Profile44 should support System.Reflection.Context inbox but contained a implementation assemblies: lib/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="portable46-net451+win81" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework .NETPortable,Version=v4.5,Profile=Profile7 should support System.Reflection.Context inbox but contained a reference assemblies: ref/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="portable45-net45+win8" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework .NETPortable,Version=v4.5,Profile=Profile7 should support System.Reflection.Context inbox but contained a implementation assemblies: lib/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="portable45-net45+win8" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework Windows,Version=v8.0 should support System.Reflection.Context inbox but contained a reference assemblies: ref/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="win8" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
    C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): Framework Windows,Version=v8.0 should support System.Reflection.Context inbox but contained a implementation assemblies: lib/netstandard1.1/System.Reflection.Context.dll.  You may need to add <InboxOnTargetFramework Include="win8" /> to your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]

I made sure that the generated nupkg has the expected state, that's why I disabled the support check.

[ericstj]

This is because S.R.C is marked as inbox in the package index. The inbox validation doesn't understand that you can decide to not represent an assembly that's inbox (here it would just get a placeholder).

I think you can make this go away by adding <InboxOnTargetFramework Include="portable-net45+win8" /> It looks like that Harvesting was only harvesting the placeholder files.

[ViktorHofer]

I can't get this working. After adding the InboxOnTargetFramework items for both portables and win8, I now get the following errors:

C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on .NETCore,Version=v5.0/win10-x86 but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="netcore50" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on .NETCore,Version=v5.0/win10-x86-aot but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="netcore50" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on .NETCore,Version=v5.0/win10-x64 but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="netcore50" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on .NETCore,Version=v5.0/win10-x64-aot but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="netcore50" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on .NETCore,Version=v5.0/win10-arm but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="netcore50" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on .NETCore,Version=v5.0/win10-arm-aot but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="netcore50" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0/win10-x86 but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0/win10-x86-aot but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0/win10-x64 but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0/win10-x64-aot but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0/win10-arm but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0/win10-arm-aot but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0.16299/win10-x86 but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0.16299" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0.16299/win10-x86-aot but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0.16299" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0.16299/win10-x64 but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0.16299" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0.16299/win10-x64-aot but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0.16299" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0.16299/win10-arm but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0.16299" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]
C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21221.6\build\Packaging.targets(1119,5): error : System.Reflection.Context should be supported on UAP,Version=v10.0.16299/win10-arm-aot but has a compile placeholder.  You may need to remove InboxOnTargetFramework Include="uap10.0.16299" /> from your project. [C:\git\runtime2\src\libraries\System.Reflection.Context\pkg\System.Reflection.Context.pkgproj]

If there isn't an easy solution to it I'd be fine to keep the support check for this package disabled.

[ericstj]

I see, because those are OOB frameworks, so the package has to provide an asset. One solution would be to remove the inbox entries from the index just for this package. That would avoid the original issue you mentioned.

runtime/src/libraries/pkg/baseline/packageIndex.json

Lines 4908 to 4913 in 1cc11b1

	"InboxOn": {
	"net45": "4.0.0.0",
	"portable46-net451+win81": "4.0.0.0",
	"portable45-net45+win8": "4.0.0.0",
	"uap10.0.16299": "4.0.3.0",
	"win8": "4.0.0.0"

Remove the portable entries and win8 (effectively "lying" about what's in those targeting packs). Alternatively you could plumb a suppression that told validation to not check for support for some frameworks (take the existing hook you added and consider using it in more places) and consume that near here: https://github.com/dotnet/arcade/blob/e7ede87875f41a9b3df898ae08da5ebc96e24f56/src/Microsoft.DotNet.Build.Tasks.Packaging/src/ValidatePackage.cs#L585

[ViktorHofer]

Thanks a lot for the suggestion Eric. I decided to trim the packageIndex graph as I wouldn't want to spend much on a solution for obsolete frameworks. Either the deprecation of the packageIndex or the removal of old netstandard1.x assets will happen at some point which will hopefully make the consideration of these old framework unnecessary.

[GrabYourPitchforks]

The removed configurations (few netstandard1.x, portable*, netcore50, net46) of the touched packages aren't built anymore. Instead the already built matching binaries from the latest available packages are redistributed when packaging these libraries.

Can you clarify what is meant by this statement? Does this mean that System.Whatever.6.0.0.0.nupkg will no longer carry netstandard1.0 assets, so anybody who targets netstandard1.0 will instead need to pull in System.Whatever.5.0.0.0.nupkg? (And that such packages are no longer supported as of 8 months from now, when the .NET 5 wave all-up goes out of support?)

[ViktorHofer]

Can you clarify what is meant by this statement? Does this mean that System.Whatever.6.0.0.0.nupkg will no longer carry netstandard1.0 assets, so anybody who targets netstandard1.0 will instead need to pull in System.Whatever.5.0.0.0.nupkg? (And that such packages are no longer supported as of 8 months from now, when the .NET 5 wave all-up goes out of support?)

Sent you more information about this offline.

[ViktorHofer]

Test failing leg was a networking hiccup when cloning the docker image. The other legs were canceled when I pushed a new commit (probably a GH race condition).