Fix CreateDefaultBuilder_SecretsDoesReload test failure
#52466
Conversation
…f this is related to the FileSystemWatcher.
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsTest failures appear to be isolated to Ubuntu 16.04, I'm wondering if this is related to the
Fixes #48696
|
| Directory.CreateDirectory(secretFileInfo.Directory.FullName); | ||
|
|
||
| static string SaveRandomSecret(string secretPath) | ||
| var originalValue = Environment.GetEnvironmentVariable("DOTNET_USE_POLLING_FILE_WATCHER"); |
There was a problem hiding this comment.
Note for reviewers:
The diff looks tough to read but seems like this change is basically just adding a try/finally block around this entire code snippet and setting DOTNET_USE_POLLING_FILE_WATCHER environment variable
also:
- config.GetReloadToken().RegisterChangeCallback(
- _ => configReloadedCancelTokenSource.Cancel(), null);
+ using IDisposable token = config.GetReloadToken().RegisterChangeCallback(
+ _ => configReloadedCancelTokenSource.Cancel(), null);
|
If we rely on polling to be set doesn't that mean we have a problem with the product, since that is not the default? |
| File.WriteAllText(secretPath, $"{{ \"Hello\": \"{newMessage}\" }}"); | ||
| return newMessage; | ||
| } | ||
| Environment.SetEnvironmentVariable("DOTNET_USE_POLLING_FILE_WATCHER", "1"); |
There was a problem hiding this comment.
Do these tests run concurrently? If so, then setting the environment variable for the entire process might effect other tests, you can use RemoteExecutor to give the test it's own process, or use API to setup the polling file-watcher.
There was a problem hiding this comment.
Ah, yes. That makes sense. I could wrap this up in the RemoteExecutor to isolate it, but I'd like to ensure first that changing this test in this way is the correct approach?
Hi @ericstj - yes, but I think this is a somewhat known issue for certain environments. In fact, I just had to update docs to mention details about this per @davidfowl, see #51866 (comment). I'm not certain that this is isolated to Ubuntu 16.04, but that is the only environment that I saw occasionally failing for this test unit test. I believed it to be related to the |
|
I'm going to abandon/close this PR. I was unable to reliably validate these changes, per #52466 (comment). |
ghost
locked as resolved and limited conversation to collaborators
Test failures appear to be isolated to Ubuntu 16.04, I'm wondering if this is related to the
FileSystemWatchernot signaling file system changes correctly."DOTNET_USE_POLLING_FILE_WATCHER"env var to"1"for the duration of the testFixes #48696