Faster unsigned division by constants #52893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
This is ready for merging. It's the same PR with just a fix for one new assert. |
tannergooding
approved these changes
May 18, 2021
|
Thank's for resolving the issue so quickly. |
ghost
locked as resolved and limited conversation to collaborators
|
@pentp - Do you know why we choose to do |
|
Happened to notice question for @pentp above. |
|
linking #54166 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #49585 rebased and updated to use the new
inst_Movmethod instead ofinst_RV_RV(INS_mov)./cc @tannergooding @EgorBo