Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename superpmi tests collection names #53108

Merged
merged 2 commits into from
May 26, 2021

Conversation

kunalspathak
Copy link
Member

After introducing libraries tests collection, whenever I filter the collection to -f libraries.pmi , the tests_libraries.pmi also gets picked up, downloaded and ran. To differentiate, I have renamed the libraries tests collection to libraries_tests.pmi and for consistency, the tests.pmi to coreclr_tests.pmi. That way, if someone specified -f tests.pmi , both libraries and coreclr collection can be downloaded and run.

  • Rename tests.pmi to coreclr_tests.pmi
  • Rename tests_libraries.pmi to libraries_tests.pmi

- Rename tests.pmi to coreclr_tests.pmi
- Rename tests_libraries.pmi to libraries_tests.pmi
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 21, 2021
@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib

@kunalspathak kunalspathak merged commit bc0fda4 into dotnet:main May 26, 2021
@BruceForstall
Copy link
Member

@kunalspathak Are you going to kick off the collection pipeline with these new names? (the last run had a couple apparently infra failures that are worth re-trying anyway)

@kunalspathak
Copy link
Member Author

Could you do it @BruceForstall ? I am outside and don't have access to the pipeline.

@BruceForstall
Copy link
Member

Done. Fyi, #51998 will soon change the GUID again.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants