Improve cancellation in StreamPipeReader.ReadAtLeastAsync #53306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
May 26, 2021
src/libraries/System.IO.Pipelines/tests/PipeReaderReadAtLeastAsyncTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <stoub@microsoft.com>
stephentoub
approved these changes
May 28, 2021
This was referenced Jun 1, 2021
davidfowl
reviewed
Jun 16, 2021
src/libraries/System.IO.Pipelines/tests/PipeReaderCopyToAsyncTests.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jun 16, 2021
src/libraries/System.IO.Pipelines/tests/PipeReaderReadAtLeastAsyncTests.cs
Outdated
Show resolved
Hide resolved
davidfowl
approved these changes
Jun 16, 2021
manandre
force-pushed
the
oce-readatleastasync
branch
from
0ceaf2d
to
eb9915d
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses post-merge comment #52246 (comment)
/cc @stephentoub