Address the feedback left on the Introducing Metrics APIs PR #53324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsThis change is addressing the feedback on the PR #52685 mainly from @stephentoub and @ViktorHofer
|
tarekgh
added
area-System.Diagnostics.Metric
and removed
area-System.Diagnostics.Tracing
labels
|
@ViktorHofer I appreciate if you can have a quick look at the commit 01f2ae4 in this PR. This just applying your previous suggestion #52685 (review) |
|
CC @noahfalk |
|
Yes thanks for applying my suggestion. The condition is much easier to follow now. |
stephentoub
reviewed
May 27, 2021
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Meter.cs
Show resolved
Hide resolved
stephentoub
approved these changes
May 27, 2021
|
The failure in the CI leg |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is addressing the feedback on the PR #52685 mainly from @stephentoub and @ViktorHofer