-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of Rijndael from EncryptedXml where possible #54238
Conversation
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis removes uses of RijndaelManaged and replaces it with Aes since as of .NET Core, the Rijndael types were a simple shim to the AES types, anyway. This removes the project-level warning ignore and adds targeted error supressions. Closes #54145.
|
Most overly signed off change ever? 😄 |
Interestingly, we already did this fix in .NET Framework. And fixed that the value didn't get disposed. |
Eh I thought about it and decided not to, but if the Framework did it, I feel more comfortable doing it. |
This matches the behavior of the .NET Framework.
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
@GrabYourPitchforks It looks like Pipelines are running... statuses just aren't getting reported to GitHub. https://dev.azure.com/dnceng/public/_build/results?buildId=1190227&view=results |
Per https://dev.azure.com/dnceng/public/_build/results?buildId=1189505&view=results, tests are passing except for some filesystem stuff which is already being tracked. |
This removes uses of RijndaelManaged and replaces it with Aes since as of .NET Core, the Rijndael types were a simple shim to the AES types, anyway.
This removes the project-level warning ignore and adds targeted error supressions.
Closes #54145.