Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add symbolic link APIs #54253

Merged
merged 51 commits into from
Jul 9, 2021
Merged

Add symbolic link APIs #54253

merged 51 commits into from
Jul 9, 2021
+1,883 −174

Commits on Jul 2, 2021

  1. ref declarations and src empty definitions

    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    b63c7b7 View commit details
    Browse the repository at this point in the history

  2. Implementation for Unix symlinks APIs and cross-platform unit tests.

    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    b223304 View commit details
    Browse the repository at this point in the history

  3. Add windows implementation of [sym]link APIs

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    2e822fd View commit details
    Browse the repository at this point in the history

  4. Use ValueStringBuilder in ResolveLinkTarget

    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    32e196c View commit details
    Browse the repository at this point in the history

  5. Build failure in FileSystemWatcher csproj due to missing new interop … 

    …dependency.
    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    8ed2772 View commit details
    Browse the repository at this point in the history

  6. Fix build failure. Address documentation suggestions.

    @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    abbecf0 View commit details
    Browse the repository at this point in the history

  7. Add missing csproj references to System.Net.Ping.Functional.Tests (pr… 

    …oject that is using ReadLink).
    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    fc49855 View commit details
    Browse the repository at this point in the history

  8. Move CanCreateSymbolicLinks from FileSystemWatcher one class above, s… 

    …o FileSystem can consume that method. Delete the duplicate CanCreateSymbolicLinks method that currently fails in the CI.
    @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    86cbd19 View commit details
    Browse the repository at this point in the history

  9. Fix some Microsoft.IO.Redist CI failures.

    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    480d3df View commit details
    Browse the repository at this point in the history

  10. Fix CI build failures from Net5Compat.Tests

    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    a6cd9da View commit details
    Browse the repository at this point in the history

  11. Clean CanCreateSymbolicLinks for readability. Remove incomplete code.

    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    6952eb7 View commit details
    Browse the repository at this point in the history

  12. Support long paths in GetFinalPathNameByHandle

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    797ace5 View commit details
    Browse the repository at this point in the history

  13. Use MS.IO.Redist friendly APIs for marshalling

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    8639e3b View commit details
    Browse the repository at this point in the history

  14. Add IsBrowser check to CanCreateSymbolicLinks

    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    6bb1aa9 View commit details
    Browse the repository at this point in the history

  15. Add more tests and fix some issues in windows

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    88bcadb View commit details
    Browse the repository at this point in the history

  16. Add path to IO_InconsistentLinkType exception msg

    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    8701118 View commit details
    Browse the repository at this point in the history

  17. Fix failure in test creating inconsistent file/dir type.

    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    d10e00c View commit details
    Browse the repository at this point in the history

  18. Fix net48 error

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    fa5ff40 View commit details
    Browse the repository at this point in the history

  19. Address CreateSymbolicLink initial check on Unix to verify pathToTarg… 

    …et is always relative to linkPath.
    @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    6788db7 View commit details
    Browse the repository at this point in the history

  20. Use RemoteExecutor for a test related to change the current working dir

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    45392b4 View commit details
    Browse the repository at this point in the history

  21. Add missing argument to exception message in MS.IO.Redist

    @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    38b6e88 View commit details
    Browse the repository at this point in the history

  22. nit: Clean comment on CreateSymbolicLink p/invoke.

    @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    a70cdef View commit details
    Browse the repository at this point in the history

  23. Fix CI bug in Windows Nano where %TEMP% points to "C:\Windows\TEMP" b… 

    …ut the actual folder name is "C:\Windows\Temp", which prevents us from using Assert.Equal for path comparison.
    @carlossanlop @jozkee
    carlossanlop authored and jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    cbcf7af View commit details
    Browse the repository at this point in the history

  24. Use ALLOW_UNPRIVILEGED_CREATE only on windows versions >= 10.0.14972

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    c43664a View commit details
    Browse the repository at this point in the history

  25. Do not use IsWindowsVersionAtLeast since isn't avail in ns2.0

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    9460264 View commit details
    Browse the repository at this point in the history

  26. Use PrintName (Dos) instead of SubstituteName (NT)

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    bbaa35a View commit details
    Browse the repository at this point in the history

  27. Fix issues related to server share paths

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    7e2eaa9 View commit details
    Browse the repository at this point in the history

  28. Fix CI issues

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    0d4250b View commit details
    Browse the repository at this point in the history

  29. Address suggestions

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    1a05a56 View commit details
    Browse the repository at this point in the history

  30. Address suggestions

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    d656aed View commit details
    Browse the repository at this point in the history

  31. Address suggestions about using PathInternal.IsExtended

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    adcca16 View commit details
    Browse the repository at this point in the history

  32. Add more scenarios for "file system entry type is inconsistent with t… 

    …hat of its target"
    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    35165b0 View commit details
    Browse the repository at this point in the history

  33. Remove duplicated validation checks

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    9d2694b View commit details
    Browse the repository at this point in the history

  34. Address suggestions for Unix

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    c79df26 View commit details
    Browse the repository at this point in the history

  35. ifdef the list of paths used for theories

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    fc4241d View commit details
    Browse the repository at this point in the history

  36. Add tests to verify the limit of followed links 

    Address suggestions
    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    4881f2b View commit details
    Browse the repository at this point in the history

  37. Fix bug related to follow links limit in Unix

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    b377cb0 View commit details
    Browse the repository at this point in the history

  38. Trim extended prefix when the passed-in path is not extended

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    496487f View commit details
    Browse the repository at this point in the history

  39. Remove helper AssertFullNameEquals since is no longer needed and fix … 

    …CI errors
    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    beaf701 View commit details
    Browse the repository at this point in the history

  40. Add a check for versions < win10 build 14972 to fix silent error

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    a5986fb View commit details
    Browse the repository at this point in the history

  41. Add Windows limit for ResolveLinkTarget to remarks

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    b7ec269 View commit details
    Browse the repository at this point in the history

  42. Remove pipe test

    @jozkee
    jozkee committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    7f37a86 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Remove lstat from ResolveLinkTarget

    @jozkee
    jozkee committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    3e36f72 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Avoid testing the reparse point/soft link limit very precisely

    @jozkee
    jozkee committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6f5b99a View commit details
    Browse the repository at this point in the history

  2. Fix LinkTarget invalidation logic

    @jozkee
    jozkee committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    2d09f7e View commit details
    Browse the repository at this point in the history

  3. Make returnFinalTarget no longer optional

    @jozkee
    jozkee committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    4b5e133 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/dotnet/runtime into symlinks

    @jozkee
    jozkee committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    82dc88a View commit details
    Browse the repository at this point in the history

  5. Try to fix failing tests found in CI

    @jozkee
    jozkee committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    48e1af1 View commit details
    Browse the repository at this point in the history

  6. Try smaller chains of links

    @jozkee
    jozkee committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    0495f59 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Avoid using GetTestFilePath in order to correctly compare against the… 

    … real temp path

Bring back previous InlineData since it wasn't the cause of the CI issue
    @jozkee
    jozkee committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    40cb737 View commit details
    Browse the repository at this point in the history

  2. Use chain length of 20 instead of 30, which fails in Win 1809

    @jozkee
    jozkee committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    995ead5 View commit details
    Browse the repository at this point in the history