Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][aot] Disable tests that are failing because they depend on stacktrace API #54286

Merged
merged 3 commits into from
Jun 16, 2021
Merged

[wasm][aot] Disable tests that are failing because they depend on stacktrace API #54286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae974dd
[wasm][aot] Update the issue number for disabled stack trace tests
radical Jun 16, 2021
583abe5
[wasm][aot] Disable tests that depend on stacktrace support
radical Jun 16, 2021
d378377
[wasm][aot] Update issue urls for tests that fail depend on stacktrac…
radical Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.IO.Pipelines/tests/FlushAsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void FlushAsync_ReturnsCompletedTaskWhenMaxSizeIfZero()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50959", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
public async Task FlushAsync_ThrowsIfWriterReaderWithException()
{
void ThrowTestException()
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.IO.Pipelines/tests/PipeReaderWriterFacts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ void ThrowTestException(Exception ex, Action<Exception> catchAction)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50959", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
public async Task ReadAsync_ThrowsIfWriterCompletedWithException()
{
ThrowTestException(new InvalidOperationException("Writer exception"), e => _pipe.Writer.Complete(e));
Expand All @@ -234,7 +234,7 @@ public async Task ReadAsync_ThrowsIfWriterCompletedWithException()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50959", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
public async Task WriteAsync_ThrowsIfReaderCompletedWithException()
{
ThrowTestException(new InvalidOperationException("Reader exception"), e => _pipe.Reader.Complete(e));
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public TestClass()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51676", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
public void StackTraceDoesNotStartWithInternalFrame()
{
string stackTrace = Environment.StackTrace;
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Runtime/tests/System/Diagnostics/StackTraceHiddenAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

namespace System.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
public class StackTraceHiddenAttributeTests
{
[Fact]
Expand Down
1 change: 1 addition & 0 deletions ...aries/System.Runtime/tests/System/Runtime/ExceptionServices/ExceptionDispatchInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ public static void SetCurrentOrRemoteStackTrace_Invalid_Throws()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
public static void SetCurrentStackTrace_IncludedInExceptionStackTrace()
{
Exception e;
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@
<!-- Issue: https://github.com/dotnet/runtime/issues/51678 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader\tests\System.Runtime.Loader.Tests.csproj" />

<!-- Issue: https://github.com/dotnet/runtime/issues/51676 -->
<!-- Issue: https://github.com/dotnet/runtime/issues/50957 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Extensions\tests\System.Runtime.Extensions.Tests.csproj" />

<!-- Issue: https://github.com/dotnet/runtime/issues/52393 -->
Expand All @@ -291,7 +291,7 @@
<!-- Issue: https://github.com/dotnet/runtime/issues/51961 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json/tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj" />

<!-- Issue: https://github.com/dotnet/runtime/issues/50959 -->
<!-- Issue: https://github.com/dotnet/runtime/issues/50957 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.Pipelines\tests\System.IO.Pipelines.Tests.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we remove the exclusions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this and more. But as a separate PR.
This one will unblock the tracking PR. And then a follow up PR would enable the ones that have been stable on the tracking one.

</ItemGroup>

Expand Down