Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Move leakwheel to Pri1 #54522

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Conversation

fanyang-mono
Copy link
Member

Fixes #53386

GC test leakwheel contains random number generator
https://github.com/dotnet/runtime/blob/main/src/tests/GC/Scenarios/LeakWheel/leakwheel.cs#L158

Half of the time it ran out of time on Android x64. I am moving this test to Pri1, due to its randomness.

@ghost
Copy link

ghost commented Jun 21, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #53386

GC test leakwheel contains random number generator
https://github.com/dotnet/runtime/blob/main/src/tests/GC/Scenarios/LeakWheel/leakwheel.cs#L158

Half of the time it ran out of time on Android x64. I am moving this test to Pri1, due to its randomness.

Author: fanyang-mono
Assignees: -
Labels:

area-AssemblyLoader-mono

Milestone: -

@fanyang-mono fanyang-mono changed the title Move leakwheel to Pri1 [Test] Move leakwheel to Pri1 Jun 21, 2021
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM infra-wise. I defer to Maoni to comment on the test as such and its categorization in greater detail.

@trylek
Copy link
Member

trylek commented Jun 21, 2021

In particular, in the Teams channel we were discussing what is the most appropriate tagging of the test, whether it's just Pri1 or something more involved like IsLongRunningGCTest. I don't think my GC expertise is sufficient to make a call on that.

@mangod9
Copy link
Member

mangod9 commented Jun 21, 2021

Hey @trylek is it possible to switch the priority only for Mono? Are the tests compiled only once or separately for coreclr and mono?

@trylek
Copy link
Member

trylek commented Jun 22, 2021

As I told @fanyang-mono earlier today, it should be theoretically possible to make long-running or other test properties dependent on the test project properties. Having said that, we're still largely struggling with a random library test failing no-one pays initial attention to as it's a networking test and these are supposed to fail once in a while. Deciding on and coding up the support for this behavior is probably the most challenging part.

@mangod9
Copy link
Member

mangod9 commented Jun 22, 2021

Ok, I think this is ok for now.

@fanyang-mono
Copy link
Member Author

Failures on windows arm64 is irrelevant.

@fanyang-mono fanyang-mono merged commit eb57372 into dotnet:main Jun 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mono] Mark long running/weird runtime tests with outer loop flag.
3 participants