-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Move leakwheel to Pri1 #54522
Conversation
Tagging subscribers to this area: @CoffeeFlux Issue DetailsFixes #53386 GC test leakwheel contains random number generator Half of the time it ran out of time on Android x64. I am moving this test to Pri1, due to its randomness.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM infra-wise. I defer to Maoni to comment on the test as such and its categorization in greater detail.
In particular, in the Teams channel we were discussing what is the most appropriate tagging of the test, whether it's just |
Hey @trylek is it possible to switch the priority only for Mono? Are the tests compiled only once or separately for coreclr and mono? |
As I told @fanyang-mono earlier today, it should be theoretically possible to make long-running or other test properties dependent on the test project properties. Having said that, we're still largely struggling with a random library test failing no-one pays initial attention to as it's a networking test and these are supposed to fail once in a while. Deciding on and coding up the support for this behavior is probably the most challenging part. |
Ok, I think this is ok for now. |
Failures on windows arm64 is irrelevant. |
Fixes #53386
GC test leakwheel contains random number generator
https://github.com/dotnet/runtime/blob/main/src/tests/GC/Scenarios/LeakWheel/leakwheel.cs#L158
Half of the time it ran out of time on Android x64. I am moving this test to Pri1, due to its randomness.