Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some recently enabled HTTP3 tests #54843

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

geoffkizer
Copy link
Contributor

Fixes #54806
Contributes to #54778

Disable the cookie tests temporarily again as they are flaky.
Disable a ConnectTimeout test permanently, as it doesn't make sense for HTTP3.

@ghost
Copy link

ghost commented Jun 28, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #54806
Contributes to #54778

Disable the cookie tests temporarily again as they are flaky.
Disable a ConnectTimeout test permanently, as it doesn't make sense for HTTP3.

Author: geoffkizer
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@geoffkizer
Copy link
Contributor Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@geoffkizer
Copy link
Contributor Author

There is a metric crapload of HttpClient tests failing with TimeoutException on this PR.

These failures must be unrelated to this PR, since all it does is disable tests.

@karelz
Copy link
Member

karelz commented Jun 28, 2021

I guess that is the reason why @jkotas filed the original issue #54778. I will try to look at test failure history to see what happened.
We may need to dig deeper into what changed where that our tests started failing ... perhaps lower-end machines or something like that?

@geoffkizer
Copy link
Contributor Author

It seems like all the TimeoutException failures are on Linux.

@ManickaP ManickaP mentioned this pull request Jun 28, 2021
@geoffkizer geoffkizer merged commit 5f8a177 into dotnet:main Jun 29, 2021
@geoffkizer geoffkizer deleted the disablehttp3tests branch June 29, 2021 17:40
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants