[mono] Revive FullAOT test lanes #55362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhameed
added
area-Infrastructure-mono
runtime-mono
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
from
5be69ea
to
fbcb36b
Compare
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
from
fbcb36b
to
7f4d48c
Compare
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
from
7f4d48c
to
7152761
Compare
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
2 times, most recently
from
f7784eb
to
2731647
Compare
imhameed
changed the title
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
5 times, most recently
from
aa3b560
to
2712982
Compare
SamMonoRT
reviewed
Aug 4, 2021
| @@ -1069,6 +1069,31 @@ jobs: | |||
| eq(dependencies.evaluate_paths.outputs['SetPathVars_runtimetests.containsChange'], true), | |||
| eq(variables['isFullMatrix'], true)) | |||
|
|
|||
| # | |||
There was a problem hiding this comment.
You should include these in the runtime staging lanes to start with, and then upgrade once we have have reliable passing runs. @imhameed
There was a problem hiding this comment.
I expect that these lanes will be as reliable as the llvmaot lanes: the changes are self-contained and these don't depend on an unreliable pool of machines (like macOS or iOS). So I don't think this will need a "break-in period" in runtime-staging.
I'm not sure yet how long the lanes will take to run but I don't expect them to be worse than the existing llvmaot lanes.
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
4 times, most recently
from
9941c3f
to
8ce1b0f
Compare
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
6 times, most recently
from
babcc06
to
9161d37
Compare
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
3 times, most recently
from
f01524f
to
049f145
Compare
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
from
ecb882e
to
23421b1
Compare
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
5 times, most recently
from
d207a3c
to
4dc9a67
Compare
…unused by the runtime tests This depends on "xunit.runner.utility.dotnet", which doesn't seem to be present in CORE_ROOT
…ddition to the test assemblies
…mpilation missing assembly failures
imhameed
force-pushed
the
monotest-llvm-fullaot
branch
from
4dc9a67
to
f7dd6e3
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't ship any products using FullAOT on Linux x64/arm64, but this
compilation mode is used for iOS, FullAOT-related issues that affect iOS are
likely to be caught by FullAOT on Linux x64/arm64, and it is a lot easier to
build, develop, and debug on desktop OSes.