Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libraries][Android][iOSSimulator] Remove Active Issues from tests no… #55974

Merged
merged 2 commits into from
Jul 21, 2021
Merged

[libraries][Android][iOSSimulator] Remove Active Issues from tests no… #55974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3312d53
[libraries][Android][iOSSimulator] Remove Active Issues from tests no…
Jul 19, 2021
5b67c54
Remove Microsoft.CSharp.Tests proj skip
Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...Model.Annotations/tests/System/ComponentModel/DataAnnotations/ValidationExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ public static void Ctor_String_ValidationAttribute_Object(string errorMessage)
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50882", TestPlatforms.Android)]
public void Ctor_SerializationInfo_StreamingContext()
{
using (var stream = new MemoryStream())
Expand Down
1 change: 0 additions & 1 deletion ...raries/System.Globalization.Calendars/tests/CalendarTestWithConfigSwitch/CalendarTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace System.Globalization.Tests
public static class CalendarTests
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/36883", TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS | TestPlatforms.Android)]
public static void TestJapaneseCalendarDateParsing()
{
CultureInfo ciJapanese = new CultureInfo("ja-JP") { DateTimeFormat = { Calendar = new JapaneseCalendar() } };
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.ObjectModel/tests/KeyedCollection/Serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public static IEnumerable<object[]> SerializeDeserialize_Roundtrips_MemberData()

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[MemberData(nameof(SerializeDeserialize_Roundtrips_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50933", TestPlatforms.Android)]
public void SerializeDeserialize_Roundtrips(TestCollection c)
{
TestCollection clone = BinaryFormatterHelpers.Clone(c);
Expand Down
1 change: 0 additions & 1 deletion ...aries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ public static IEnumerable<object[]> SerializeDeserialize_Roundtrips_MemberData()

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[MemberData(nameof(SerializeDeserialize_Roundtrips_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50933", TestPlatforms.Android)]
public void SerializeDeserialize_Roundtrips(ObservableCollection<int> c)
{
ObservableCollection<int> clone = BinaryFormatterHelpers.Clone(c);
Expand Down
1 change: 0 additions & 1 deletion ...ries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionary_SerializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public static IEnumerable<object[]> SerializeDeserialize_Roundtrips_MemberData()

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[MemberData(nameof(SerializeDeserialize_Roundtrips_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50933", TestPlatforms.Android)]
public void SerializeDeserialize_Roundtrips(ReadOnlyDictionary<string, string> d)
{
ReadOnlyDictionary<string, string> clone = BinaryFormatterHelpers.Clone(d);
Expand Down
1 change: 0 additions & 1 deletion ...del/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollection_SerializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ public static IEnumerable<object[]> SerializeDeserialize_Roundtrips_MemberData()

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[MemberData(nameof(SerializeDeserialize_Roundtrips_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50933", TestPlatforms.Android)]
public void SerializeDeserialize_Roundtrips(ReadOnlyObservableCollection<int> c)
{
ReadOnlyObservableCollection<int> clone = BinaryFormatterHelpers.Clone(c);
Expand Down
1 change: 0 additions & 1 deletion ...zation.Primitives/tests/System/Runtime/Serialization/InvalidDataContractExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public void Ctor_String_Exception(string message)
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50936", TestPlatforms.Android)]
public void Ctor_SerializationInfo_StreamingContext()
{
using (var memoryStream = new MemoryStream())
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Text.RegularExpressions/tests/RegexMatchTimeoutExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public void Ctor()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50942", TestPlatforms.Android)]
public void SerializationRoundtrip()
{
const string Input = "abcdef";
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.netcoreapp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ public void Parse_Netcoreapp(string pattern, RegexOptions options, object error,
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50942", TestPlatforms.Android)]
public void RegexParseException_Serializes()
{
#pragma warning disable RE0001 // Regex issue: Not enough )'s
Expand Down Expand Up @@ -141,7 +140,7 @@ static partial void Throws(RegexParseError error, int offset, Action action)
throw new XunitException($"Expected RegexParseException with error: ({error}) -> Actual error: {regexParseError})");
}
catch (Exception e)
{
{
throw new XunitException($"Expected RegexParseException -> Actual: ({e})");
}

Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Threading.Channels/tests/ChannelClosedExceptionTests.netcoreapp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace System.Threading.Channels.Tests
public partial class ChannelClosedExceptionTests
{
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50943", TestPlatforms.Android)]
public void Serialization_Roundtrip()
{
var s = new MemoryStream();
Expand Down
3 changes: 0 additions & 3 deletions src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,6 @@
<!-- Runs an fails on arm64 https://github.com/dotnet/runtime/issues/37094 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Security.Cryptography.Pkcs\tests\System.Security.Cryptography.Pkcs.Tests.csproj" />

<!-- https://github.com/dotnet/runtime/issues/50864 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.CSharp\tests\Microsoft.CSharp.Tests.csproj" />

<!-- https://github.com/dotnet/runtime/issues/50871 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.Extensions.DependencyInjection\tests\DI.Tests\Microsoft.Extensions.DependencyInjection.Tests.csproj" />

Expand Down