Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries solution and NuGet.config files #56430

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jul 27, 2021

Commit 1: Updating slngen to latest version and its invocation.
Commit 2: Update the NuGet.config files
Commit 3: Update solution files with slngen

2 and 3 were done with this command: dotnet build src\libraries\slngen.proj.

@ghost
Copy link

ghost commented Jul 27, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Updating slngen to latest version and its invocation.
  2. Update the NuGet.config files
  3. Update solution files with slngen

2 and 3 were done with this command: dotnet build src\libraries\slngen.proj.

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please spot-check the common SLN's that are most used (EG: Microsoft.Extensions.Logging, System.Text.Json, System.Runtime, etc)

I'll pull this and do the same.

@ViktorHofer
Copy link
Member Author

LGTM. Please spot-check the common SLN's that are most used (EG: Microsoft.Extensions.Logging, System.Text.Json, System.Runtime, etc)

Already did locally while they were generated. Didn't see anything standing out but a second pair of eyes are appreciated :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants