Handle FileNotFound for symlinks when using polling #56915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io |
jozkee
force-pushed
the
symlink-polling-retry
branch
from
fa3d312
to
a9ecb2d
Compare
danmoseley
reviewed
Aug 10, 2021
| // Try one more time, if it fails again just give up. | ||
| if (!isSecondTry) | ||
| { | ||
| GetFileLinkTargetLastWriteTimeUtc(fileInfo, isSecondTry: true); |
There was a problem hiding this comment.
@jozkee I'm missing something, shouldn't this return a value?
There was a problem hiding this comment.
It would be interesting to have an analyzer that flagged ignored return values, although it would be hugely noisy presumably @stephentoub
There was a problem hiding this comment.
@danmoseley great catch, I've sent #57136 to address that
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56190
Fixes #56643
Fixes #57128