-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sgen: Update GetTempAssemblyName according to #46499 #57026
Sgen: Update GetTempAssemblyName according to #46499 #57026
Conversation
In #46499 we corrected Compilation.GetTempAssemblyName in order for it to be not deterministic under .NET Core. In this PR we update the generated filename to match the new logic.
Avoid using external dependency
Avoid using external dependency
Fixed compilation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for @HongGit about the target framework, but otherwise this looks good. I'll let Hong have a chance to review and merge.
return ReadUInt32BigEndian(hash); | ||
} | ||
|
||
private static uint ReadUInt32BigEndian(byte[] value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we include our own implementation of ReadUInt32BigEndian() here because the framework version is netstandard2.1, while this tool targets netstandard2.0? If that's the case, I think this is fine.
@HongGit, do we have any plans to update the targetframework for this tool, or are we sticking to netstandard2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we are still sticking to netstandard2.0. If there is a need to update, we could consider to.
In #46499 we corrected Compilation.GetTempAssemblyName in order for it to be not deterministic under .NET Core.
In this PR we update the generated filename to match the new logic.