Automatically generate .NETStandard compat errors #57057
Conversation
ViktorHofer
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsBefore this change, a project had to explicitly add a Automate this logic so that projects don't need to specify the item
|
Before this change, a project had to explicitly add a NETStandardCompatError item to declare that a given tfm range shouldn't be supported when packaging. Automate this logic so that projects don't need to specify the item themselves anymore. Instead condition the NETStandardCompatError target calcuation logic on the existence of both a .NETStandard and a .NETCoreApp tfm.
ViktorHofer
force-pushed
the
NetStandardCompatErrorAutomation
branch
from
77fb8ab
to
32d6988
Compare
| .NETCoreApp. This prohibits users to consume packages on an older .NETCorAapp version | ||
| than the minimum supported one. --> | ||
| <ItemGroup Condition="'$(DisableNETStandardCompatErrorForNETCoreApp)' != 'true'"> | ||
| <NETStandardCompatError Include="netcoreapp2.0" |
There was a problem hiding this comment.
how would this work after we dead end netcoreapp2.1 or netcoreapp3.1 ? would we have to change it ? can we store it in a property which points to the last netcoreapp framework that went out of support.
There was a problem hiding this comment.
netcoreapp2.1 is already out-of-support and not included in packages. The Include defines the lower boundary for which to throw and the Supported attribute the upper exclusive boundary. In this case an error is thrown for netcoreapp2.0 - netcoreapp3.0. On netcoreapp3.1 (= the $(NetCoreAppMinimum)) no exception is thrown.
Example of the System.Drawing.Common nuget package:
This means that as long as the $(NetCoreAppMinimum) property marks the minimum supported version, this logic doesn't need to be updated. For NET7 we might want to add another item for NETFramework as net461 will be out of support by when NET7 ships.
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Before this change, a project had to explicitly add a
NETStandardCompatError item to declare that a given tfm range
shouldn't be supported when packaging.
Automate this logic so that projects don't need to specify the item
themselves anymore. Instead condition the NETStandardCompatError target
calcuation logic on the existence of both a .NETStandard and a
.NETCoreApp tfm.