Don't blank out SpecialFolders on Android if they don't already exist #58064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
reviewed
Aug 25, 2021
This should give the same output as legacy Xamarin. If it doesn't, I messed up
directhex
force-pushed
the
android-specialfolders
branch
from
b7a4d01
to
ad4b9b2
Compare
steveisok
approved these changes
Aug 27, 2021
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1182508214 |
marek-safar
reviewed
Aug 30, 2021
| { | ||
| private static Dictionary<SpecialFolder, string>? s_specialFolders; | ||
|
|
||
| private static string GetFolderPathCore(SpecialFolder folder, SpecialFolderOption option) |
There was a problem hiding this comment.
I think the code should handle SpecialFolderOption.Create
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35490
Hopefully, anyway. I couldn't get local testing to run on an Android emulator at all