Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The signal enum in the native library should match the managed code. #58658

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

JamesWTruher
Copy link
Contributor

the native library enum for the posix signal and the managed enum PosixSignal don't match and they probably should.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 3, 2021
@stephentoub stephentoub added this to the 6.0.0 milestone Sep 4, 2021
@tmds
Copy link
Member

tmds commented Sep 4, 2021

Oops... poor copy-pasting. I checked the other values, they are in order.

Thank you for fixing!

@stephentoub
Copy link
Member

Is it possible to write tests that would catch this, even if manual ones?

@stephentoub
Copy link
Member

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1200970208

@tmds
Copy link
Member

tmds commented Sep 4, 2021

Is it possible to write tests that would catch this, even if manual ones?

We can add/update a test so it uses the kill executable with a signal name. That way we check our own mapping against that of kill. I'll look into it.

@stephentoub
Copy link
Member

Thanks, Tom.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants