Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Support JsonExtensionData in STJ source-gen #59047

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 13, 2021

Backport of #58912 to release/6.0

Fixes #58273 for 6.0.

/cc @eiriktsarpalis @layomia

Customer Impact

Fixes incomplete (major) scenario for new 6.0 source-gen feature: JsonExtensionData support.

Testing

Tests have been shared to ensure functional parity between src-gen and reflection serializers.

Risk

Low risk to existing reflection-based serializer (i.e. no changes to tests and limited changes to src/ implementation). Low risk for src-gen as well - it is new and shares same tests with pre-existing serializer.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Sep 13, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #58912 to release/6.0

/cc @eiriktsarpalis @layomia

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: -

@eiriktsarpalis
Copy link
Member

We need to backport #58993 after this is merged.

@eiriktsarpalis eiriktsarpalis added this to the 6.0.0 milestone Sep 13, 2021
@danmoseley
Copy link
Member

Approved. JsonExtensionData is fairly widely used and does not work with this new source generator feature. Churn is largely limited to the generator.

@danmoseley
Copy link
Member

I'm going to merge this because there is no sign of CI improving before the branch, the possibility of OS-specific bugs in the blocked queues in this change is very small, and other PR's are blocked on this.

@danmoseley danmoseley merged commit db4c0c2 into release/6.0 Sep 14, 2021
@danmoseley danmoseley deleted the backport/pr-58912-to-release/6.0 branch September 14, 2021 16:26
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants