Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing total code size through when doing SPMI diffs #60124

Merged
merged 4 commits into from
Oct 8, 2021
Merged

Support passing total code size through when doing SPMI diffs #60124

merged 4 commits into from
Oct 8, 2021

Commits on Oct 7, 2021

  1. Support passing total code size through when doing SPMI diffs 

    Currently the total code bytes shown for the base/diff is misleading
when SPMI is used because SPMI generates only .dasm files for method
contexts with diffs. This change:

* Adds -baseMetricsSummary and -diffMetricsSummary to SPMI, which
  specifies a file path to output metrics. Currently that's just the
  number of failing/succeeding compiles, and the total number of code
  bytes, but the hope is to use this for other metrics as well.
* Adds --override-total-base-metric and --override-total-diff-metric to
  jit-analyze, to support overriding the computed total base and total
  diff metric, since they are misleading when .dasm files are only
  created for differences
* Supports this from the superpmi.py wrapper script for asmdiffs when no
  explicit metric is provided: in this case, the script will get the
  metrics from SPMI and pass them to jit-analyze to override the
  computed totals.

The net result is that the displayed results from jit-analyze after SPMI
runs are less misleading and should be more comparable to similar PMI
runs.
    @jakobbotsch
    jakobbotsch committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    993511b View commit details
    Browse the repository at this point in the history

  2. Adapt to use PAL

    @jakobbotsch
    jakobbotsch committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    38b9176 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary makefile change

    @jakobbotsch
    jakobbotsch committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    b049852 View commit details
    Browse the repository at this point in the history

  4. Fix GCC build

    @jakobbotsch
    jakobbotsch committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    5577102 View commit details
    Browse the repository at this point in the history