Add SetLastError to GdiPlus methods (#59096) #60201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System.Drawing uses the last Win32 error in CheckErrorStatus to try to guess at why a GdiPlus draw method failed and ignore some failures. This was broken in .NETCore when SetLastError was removed from PINvokes. Bring back SetLastError for all PInvokes that use CheckErrorStatus.
|
Tagging subscribers to this area: @safern, @tarekgh Issue DetailsBackport of #59096 to release/5.0 Issue: #58741 Customer ImpactRegression from .NETFramework and .NETCore causing a unexpected TestingManually verified in debugger. Unit tests. RiskVery low. Adds back SetLastError to only those PINvokes which require it.
|
danmoseley
approved these changes
Oct 8, 2021
tarekgh
approved these changes
Oct 8, 2021
@ericstj did you look for that info when doing the initial fix on main and 6.0? |
safern
added
Servicing-approved
Anipik
approved these changes
Oct 11, 2021
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
approved these changes
Oct 13, 2021
|
failures are unrelated so merging this one. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59096 to release/5.0
Issue: #58741
Customer Impact
Regression from .NETFramework and .NETCore causing a unexpected
ExternalExceptionrelated to session transitions (sleep/wake, Remote Desktop, etc)Testing
Manually verified in debugger. Unit tests.
Risk
Very low. Adds back SetLastError to only those PINvokes which require it.